Page MenuHomePhabricator

Upgrade prettier, modify options
ClosedPublic

Authored by dish on Sep 15 2020, 6:53 PM.

Details

Summary
  • Upgrade prettier to 2.1.1
  • .prettierrc -> .prettierrc.js so we can have comments
  • Set a few options
Test Plan

arc lint

Diff Detail

Repository
R1 dagster
Branch
dish-upgrade-prettier (branched from master)
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

js_modules/dagit/.prettierrc.js
6

These are the relevant options.

  • trailingComma seems noncontroversial
  • The singleQuote and bracketSpacing changes are personal preferences

Feel free to push back or overrule me if you have strong opinions here!

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 15 2020, 7:07 PM
Harbormaster failed remote builds in B18324: Diff 22243!
  • Don't need these eslint changes in this diff
dish requested review of this revision.Sep 15 2020, 7:40 PM
This revision is now accepted and ready to land.Sep 15 2020, 8:05 PM
This revision was automatically updated to reflect the committed changes.