Page MenuHomePhabricator

Fix top nav on dagit Runs
ClosedPublic

Authored by dish on Sep 14 2020, 8:20 PM.

Details

Summary

Repair the collapsing top nav on the dagit Runs page in Safari by preventing the nav flex item from shrinking.

Additionally, remove the min-height from ScrollContainer -- from what I can tell, we don't need it. Please correct me if this is not the case. :)

Resolves #2891

Test Plan

View dagit Runs in Chrome/Safari. Verify that the nav does not vertically shrink for any window height.

Also verify that other ScrollContainer use cases seem to be operating fine without the min-height value.

Diff Detail

Repository
R1 dagster
Branch
dish-heights
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 14 2020, 8:42 PM
Harbormaster failed remote builds in B18299: Diff 22201!
Harbormaster returned this revision to the author for changes because remote builds failed.Sep 14 2020, 9:01 PM
Harbormaster failed remote builds in B18303: Diff 22207!
dish requested review of this revision.Sep 14 2020, 9:26 PM

Additionally, remove the min-height from ScrollContainer -- from what I can tell, we don't need it. Please correct me if this is not the case. :)

im going to let this sit for a bit since i do now know the answer to this Q

This revision is now accepted and ready to land.Sep 15 2020, 4:07 PM
This revision was automatically updated to reflect the committed changes.