Page MenuHomePhabricator

yarn rm fs
ClosedPublic

Authored by alangenfeld on Jun 20 2019, 8:29 PM.

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alangenfeld created this revision.Jun 20 2019, 8:29 PM
natekupp accepted this revision.Jun 20 2019, 9:00 PM
This revision is now accepted and ready to land.Jun 20 2019, 9:00 PM

do we know how we got this dep in the first place? anything we need to do to prevent re-introducing in the future?

do we know how we got this dep in the first place? anything we need to do to prevent re-introducing in the future?

looks like it got picked up trying to solve a strange typescript errors - i dont think its likely it will happen again

This revision was automatically updated to reflect the committed changes.

Looks good to me! Super weird this happened. (Also separately, it seems like calling a node module fs shouldn't be allowed...)