Page MenuHomePhabricator

[dagit] schedule specific page clarity
ClosedPublic

Authored by alangenfeld on Sep 12 2020, 5:15 PM.

Details

Summary

I spent way too long trying to figure out why I couldn't find the reconcile button for a newly defined schedule. I was clicking on the schedule in the left hand column which was bringing me to a page titled "Schedules" but was actually just the page for a single schedule. I totally miseed the "View All" button in the left nav.

This diff makes Schedules a link and adjusts the header to be Schedules > schedule_name .

Test Plan

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

@sashank you think it would also be good to surface a reconcile button for new defs in the instance level scheduler page ?

js_modules/dagit/src/schedules/ScheduleRoot.tsx
50

this feels very programmer-art, im sure theres a better visual treatment here

prha added inline comments.
js_modules/dagit/src/schedules/ScheduleRoot.tsx
50

I usually use a blueprint icon for this: <Icon icon="chevron-right" />

This revision is now accepted and ready to land.Sep 14 2020, 3:37 PM
sashank added inline comments.
js_modules/dagit/src/schedules/ScheduleRoot.tsx
50

If you want to go all out you can use: https://blueprintjs.com/docs/#core/components/breadcrumbs

@sashank you think it would also be good to surface a reconcile button for new defs in the instance level scheduler page ?

Yes definitely - it would be nice to just do everything from the instance level page, and you're right that the current reconcile stuff is impossible to find. I can put up a diff for this today.

This revision was automatically updated to reflect the committed changes.