Page MenuHomePhabricator

#2887 enable subset reexecution when part of selection failed
ClosedPublic

Authored by yuhan on Sep 10 2020, 8:41 AM.

Details

Summary

https://github.com/dagster-io/dagster/issues/2887

current: every step in the selection has to be either finished or succeeded

for example, in pipeline like


currently in dagit, when branch_1_0 failed and branch_2_* is still running, the user can't re-execute branch_1_0* because branch_1_1 hasn't started.

so we want to enable subset re-execution for selection where part of the selected steps failed and pipeline is still running.

Test Plan

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

yuhan edited the test plan for this revision. (Show Details)
Harbormaster returned this revision to the author for changes because remote builds failed.Sep 10 2020, 9:07 AM
Harbormaster failed remote builds in B18168: Diff 22029!
Harbormaster returned this revision to the author for changes because remote builds failed.Sep 10 2020, 5:14 PM
Harbormaster failed remote builds in B18175: Diff 22037!
yuhan requested review of this revision.Sep 10 2020, 6:44 PM
prha added inline comments.
js_modules/dagit/src/runs/RunActionButtons.tsx
111

*isFailureInSelection

This revision is now accepted and ready to land.Sep 14 2020, 4:59 PM
js_modules/dagit/src/runs/RunActionButtons.tsx
111

goodcatch