Page MenuHomePhabricator

check required resources for pipeline-level hooks
ClosedPublic

Authored by yuhan on Sep 10 2020, 7:26 AM.

Details

Summary

when a hook's required resource isn't specified, we should raise an invalid definition error
found in https://dagster.slack.com/archives/GU72HU64R/p1598895103000700

the bug only occured when a hook is applied on a pipeline, because we missed the check for pipeline-level hooks

Test Plan

bk

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 10 2020, 7:42 AM
Harbormaster failed remote builds in B18167: Diff 22028!
Harbormaster returned this revision to the author for changes because remote builds failed.Sep 10 2020, 5:16 PM
Harbormaster failed remote builds in B18176: Diff 22038!
Harbormaster returned this revision to the author for changes because remote builds failed.Sep 10 2020, 6:42 PM
Harbormaster failed remote builds in B18184: Diff 22050!
yuhan requested review of this revision.Sep 10 2020, 7:16 PM
This revision is now accepted and ready to land.Sep 10 2020, 7:26 PM