Page MenuHomePhabricator

generate synthetic step fail event when k8s step job raises a DagsterK8sError
ClosedPublic

Authored by catherinewu on Sep 3 2020, 5:35 AM.

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 3 2020, 5:56 AM
Harbormaster failed remote builds in B17827: Diff 21657!

remove aws imports from dagster graphql

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 3 2020, 8:01 AM
Harbormaster failed remote builds in B17837: Diff 21667!
python_modules/libraries/dagster-celery-k8s/dagster_celery_k8s/executor.py
439–445

why not just build SerializableErrorInfo directly from e here?

catherinewu marked an inline comment as done.

use error=serializable_error_info_from_exc_info(sys.exc_info()),

This revision is now accepted and ready to land.Sep 28 2020, 8:03 PM