Page MenuHomePhabricator

add gaps in cli test cases for backfill CLI
ClosedPublic

Authored by prha on Sep 1 2020, 11:59 PM.

Details

Summary

checked coveralls, found uncovered lines in backfill CLI

Test Plan

bk

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 2 2020, 12:19 AM
Harbormaster failed remote builds in B17801: Diff 21625!
Harbormaster returned this revision to the author for changes because remote builds failed.Sep 2 2020, 3:35 AM
Harbormaster failed remote builds in B17803: Diff 21627!
prha requested review of this revision.Sep 2 2020, 3:59 PM

^ spurious

dgibson added inline comments.
python_modules/dagster/dagster_tests/cli_tests/command_tests/test_schedule_commands.py
137–138

these are always in a consistent order right?

This revision is now accepted and ready to land.Sep 4 2020, 6:37 PM
python_modules/dagster/dagster_tests/cli_tests/command_tests/test_schedule_commands.py
137–138

Yes, I believe so. Will double check before landing.

This revision was landed with ongoing or failed builds.Sep 4 2020, 8:01 PM
This revision was automatically updated to reflect the committed changes.