Page MenuHomePhabricator

[trigger-5] add UI presence for triggers in left nav, dashboard
AbandonedPublic

Authored by prha on Aug 28 2020, 8:04 PM.

Details

Test Plan

bk

Diff Detail

Repository
R1 dagster
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 28 2020, 8:18 PM
Harbormaster failed remote builds in B17762: Diff 21578!
prha requested review of this revision.Aug 28 2020, 8:39 PM
js_modules/dagit/src/TriggersRoot.tsx
88

if matching.length > 1, should we make multiple divs?

js_modules/dagit/src/nav/TriggersList.tsx
44

iincludes?

prha retitled this revision from [triggers-5] add UI presence for triggers in left nav, dashboard to [trigger-5] add UI presence for triggers in left nav, dashboard.Aug 31 2020, 5:00 PM
js_modules/dagit/src/TriggersRoot.tsx
88

There should only be one match, but planning for the case where a trigger can prompt multiple executions.

js_modules/dagit/src/nav/TriggersList.tsx
44

defined in line 13

sashank added inline comments.
js_modules/dagit/src/App.tsx
45–46

Do we want to do any sort of feature flag opt-in?

This revision is now accepted and ready to land.Sep 3 2020, 11:57 PM