Page MenuHomePhabricator

[trigger-4] read queries for trigger graphql
AbandonedPublic

Authored by prha on Aug 27 2020, 5:10 PM.

Details

Test Plan

bk

Diff Detail

Repository
R1 dagster
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

prha retitled this revision from read queries for trigger graphql to [trigger-4] read queries for trigger graphql.Aug 27 2020, 5:12 PM
prha added a reviewer: schrockn.
Harbormaster returned this revision to the author for changes because remote builds failed.Aug 27 2020, 5:25 PM
Harbormaster failed remote builds in B17574: Diff 21373!
prha requested review of this revision.Aug 28 2020, 5:42 PM
python_modules/dagster-graphql/dagster_graphql/implementation/fetch_triggers.py
47

i think it could be a little unexpected that trigger_execution launches a run per match, but get_trigger_definition_or_error only returns the first match?

71

tags instead of run_config?

python_modules/dagster-graphql/dagster_graphql/implementation/fetch_triggers.py
47

yeah, we should probably have a check.invariant that there's only one. I believe the repository already does this in terms of enforcing there are not duplicate names.

71

good catch will fix

seems like the exact goal of the triggers stuff is a bit up in the air - but given the current impl in the python lair this GraphQL exposure makes sense.

This revision is now accepted and ready to land.Sep 9 2020, 6:51 PM