Page MenuHomePhabricator

[trigger-3] Add graphql endpoint to trigger execution based off trigger name
ClosedPublic

Authored by prha on Aug 25 2020, 10:41 PM.

Details

Summary

Triggers are detected off of a graphql mutation, which requires a running dagit server, bypassing any storage layer

Test Plan

bk

Diff Detail

Repository
R1 dagster
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 25 2020, 11:17 PM
Harbormaster failed remote builds in B17467: Diff 21247!
prha requested review of this revision.Aug 25 2020, 11:36 PM
python_modules/dagster-graphql/dagster_graphql/implementation/execution/trigger.py
40

check.invariant? (for consistency)

Seems good to get this out as experimental

This revision is now accepted and ready to land.Aug 27 2020, 8:38 PM
js_modules/dagit/src/schema.graphql
638

maybe we can prefix this with experimental

js_modules/dagit/src/schema.graphql
638

I tend to not think of graphql schema as a public API. This will only have an effect if the trigger is defined, which will generate a warning.

js_modules/dagit/src/schema.graphql
638

agreed. plus a rename causes thrash in terms of rebuilding dagit, regenn'ing ts, etc