Page MenuHomePhabricator
Differential D4285

[trigger-3] Add graphql endpoint to trigger execution based off trigger name
ClosedPublic
Actions

Authored by prha on Aug 25 2020, 10:41 PM.

Details

Reviewers
alangenfeld
sashank
schrockn
Commits
R1:9dea17d7a16f: [trigger-3] Add graphql endpoint to trigger execution based off trigger name
Summary

Triggers are detected off of a graphql mutation, which requires a running dagit server, bypassing any storage layer

Test Plan

bk

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

prha created this revision.Aug 25 2020, 10:41 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Aug 25 2020, 11:17 PM
Harbormaster failed remote builds in B17467: Diff 21247!
prha updated this revision to Diff 21254.Aug 25 2020, 11:21 PM

rebase, update

Harbormaster completed remote builds in B17471: Diff 21254.Aug 25 2020, 11:36 PM
prha requested review of this revision.Aug 25 2020, 11:36 PM
schrockn added inline comments.Aug 26 2020, 2:32 AM
python_modules/dagster-graphql/dagster_graphql/implementation/execution/trigger.py
40

check.invariant? (for consistency)

prha added a subscriber: catherinewu.Aug 26 2020, 11:34 PM
sashank accepted this revision.Aug 27 2020, 8:38 PM

Seems good to get this out as experimental

This revision is now accepted and ready to land.Aug 27 2020, 8:38 PM
sashank added inline comments.Aug 27 2020, 9:01 PM
js_modules/dagit/src/schema.graphql
637

maybe we can prefix this with experimental

prha added inline comments.Aug 28 2020, 5:26 PM
js_modules/dagit/src/schema.graphql
637

I tend to not think of graphql schema as a public API. This will only have an effect if the trigger is defined, which will generate a warning.

schrockn added inline comments.Aug 28 2020, 7:00 PM
js_modules/dagit/src/schema.graphql
637

agreed. plus a rename causes thrash in terms of rebuilding dagit, regenn'ing ts, etc

Closed by commit R1:9dea17d7a16f: [trigger-3] Add graphql endpoint to trigger execution based off trigger name (authored by prha). · Explain WhySep 4 2020, 8:30 PM
This revision was automatically updated to reflect the committed changes.
prha added a commit: R1:9dea17d7a16f: [trigger-3] Add graphql endpoint to trigger execution based off trigger name.

Revision Contents
Changeset List

PathSize
js_modules/
dagit/
src/
13 lines
python_modules/
dagster-graphql/
dagster_graphql/
client/
17 lines
implementation/
5 lines
execution/
1 line
61 lines
schema/
13 lines
30 lines
dagster_graphql_tests/
graphql/
10 lines
23 lines
dagster/
dagster/
core/
host_representation/
2 lines

Diff 21814

View Options

js_modules/dagit/src/filteredSchema.generated.json

Loading...
View Options

js_modules/dagit/src/schema.graphql

Loading...
View Options

python_modules/dagster-graphql/dagster_graphql/client/query.py

Loading...
View Options

python_modules/dagster-graphql/dagster_graphql/implementation/context.py

Loading...
View Options

python_modules/dagster-graphql/dagster_graphql/implementation/execution/__init__.py

Loading...
View Options

python_modules/dagster-graphql/dagster_graphql/implementation/execution/trigger.py

Loading...
View Options

python_modules/dagster-graphql/dagster_graphql/schema/errors.py

Loading...
View Options

python_modules/dagster-graphql/dagster_graphql/schema/roots.py

Loading...
View Options

python_modules/dagster-graphql/dagster_graphql_tests/graphql/setup.py

Loading...
View Options

python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_triggers.py

Loading...
View Options

python_modules/dagster/dagster/core/host_representation/external.py

Loading...