Page MenuHomePhabricator

Render composite mappings, external deps on the DAG
ClosedPublic

Authored by alangenfeld on Jun 19 2019, 3:50 AM.

Details

Summary

This diff:

  • Separates the composite "container" to show both the invocation and the definition (within it.)
  • Shows the composite's mapped IOs on the definition, connected to the internal solids by thin green lines.
  • Shows the composite's dependedBy and dependsOn edges as small text+circle icons outside the composite.
  • Makes the selection border less aggressive in the minified view
  • Refactors DAG React components into smaller, more re-usable chunks and formalizes the "highlighted edges" structure used for highlighting.

Notes:

  • I also updated us to TypeScript 3.5 because they've made incremental compilation quite a bit faster!
  • You can double click the text+circle of an external dependency to jump to that solid.

I have ~mostly~ tested that the external dependencies of a composite are rendered properly, but we may need to create a composite that has a ton of mapped inputs and outputs to verify that the worst-case renders acceptably well.

Test Plan

Give it a spin

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

bengotow created this revision.Jun 19 2019, 3:50 AM
bengotow edited the summary of this revision. (Show Details)Jun 19 2019, 3:56 AM
bengotow added reviewers: schrockn, alangenfeld.
alangenfeld commandeered this revision.Jun 19 2019, 9:11 PM
alangenfeld edited reviewers, added: bengotow; removed: alangenfeld.
alangenfeld added inline comments.
js_modules/dagit/src/PipelineExplorer.tsx
100–102

what exactly is this special case for?

alangenfeld updated this revision to Diff 2144.Jun 19 2019, 9:19 PM

commandeer

This revision was not accepted when it landed; it landed in state Needs Review.Jun 19 2019, 9:54 PM
This revision was automatically updated to reflect the committed changes.