Page MenuHomePhabricator

set up eslint for docs
AbandonedPublic

Authored by yuhan on Aug 12 2020, 4:33 AM.

Details

Reviewers
sashank
Test Plan

Diff Detail

Repository
R1 dagster
Branch
yuhan/doc-issues
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

yuhan requested review of this revision.Aug 12 2020, 4:47 AM
yuhan added a reviewer: sashank.
yuhan retitled this revision from set up lint for docs to set up eslint for docs.
sashank requested changes to this revision.Aug 13 2020, 4:39 PM

This looks great, thanks for doing this! Can you explain the regex change - just want to make sure that won't break any links in a weird way

docs/next/src/__tests__/mdxInternalLinks.test.ts
76โ€“77

Delete?

docs/next/src/components/AnchorHeading.tsx
33

Can you explain the change here?

docs/next/src/components/Search.tsx
32

Delete

74

This works ๐Ÿ‘

docs/next/src/components/Transition.js
2

I would double check if you're supposed to import React

I think you have to import it in components, but not pages, so this looks right.

This revision now requires changes to proceed.Aug 13 2020, 4:39 PM

I think we can abandon this and revisit when we have the new site

This revision now requires review to proceed.Dec 1 2020, 5:46 PM