Page MenuHomePhabricator

kind cluster info dump in buildkite
ClosedPublic

Authored by johann on Aug 10 2020, 6:22 PM.

Details

Summary

Run kubectl cluster-info dump after each test session.

Currently not the best debugging tool but should definitely help

  • results of all test cases are grouped together
  • hard to browse, maybe better if results were just zipped so they could be browsed locally? On the other hand it's nice to open logs in the browser
  • system logs and config are going to be noise for the most part
  • results of kubectl describe would be useful for the class of errors involving configuration

Buildkite does no garbage collection of these, that will be up to us to figure out at some point

https://buildkite.com/dagster/dagster-diffs/builds/7422#845ecf23-a480-44e2-9873-459eb8d4e8a3/1

Test Plan

manual

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 10 2020, 7:10 PM
Harbormaster failed remote builds in B16738: Diff 20412!
Harbormaster returned this revision to the author for changes because remote builds failed.Aug 10 2020, 10:06 PM
Harbormaster failed remote builds in B16743: Diff 20417!
johann retitled this revision from bk kind cluster info dump to kind cluster info dump in buildkite.Aug 10 2020, 10:29 PM
johann edited the summary of this revision. (Show Details)
johann added reviewers: nate, catherinewu.
johann edited the summary of this revision. (Show Details)
johann edited the summary of this revision. (Show Details)

see one comment, otherwise LGTM! thanks for setting this up

integration_tests/python_modules/dagster-k8s-test-infra/dagster_k8s_test_infra/kind.py
17

does this resolve to the path in the image above, or /kind-info-dump? would be nice to avoid the long path prefix if possible to make scanning the list of files less noisy

152

whooops

This revision is now accepted and ready to land.Aug 10 2020, 11:16 PM
This revision was automatically updated to reflect the committed changes.