Page MenuHomePhabricator
Differential D4140

test subset execution in celery-k8s
ClosedPublic
Actions

Authored by johann on Aug 7 2020, 5:32 PM.

Details

Reviewers
nate
prha
max
yuhan
Commits
R1:3b83a22ae9d4: test subset execution in celery-k8s
Summary

Test subset execution with partial config

Fail without fix: https://buildkite.com/dagster/dagster-diffs/builds/7387#0a0f4eb4-103a-45fd-ab6d-7e1a01985404/698-779

This will be a nasty test to debug if it fails again, because the error message only shows up in the step job logs. We only copy the run coordinator logs here. https://github.com/dagster-io/dagster/issues/2793 could help with this in the future.

Test Plan

Verified that this fails without https://dagster.phacility.com/D4139

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

johann created this revision.Aug 7 2020, 5:32 PM
Harbormaster completed remote builds in B16698: Diff 20363.Aug 7 2020, 5:48 PM
johann requested review of this revision.Aug 7 2020, 5:48 PM
johann updated this revision to Diff 20374.Aug 7 2020, 7:43 PM

up

Harbormaster failed remote builds in B16705: Diff 20374!Aug 7 2020, 8:17 PM
johann updated this revision to Diff 20381.Aug 7 2020, 9:08 PM

rebase

johann edited the summary of this revision. (Show Details)Aug 7 2020, 9:09 PM
johann edited the test plan for this revision. (Show Details)
johann added reviewers: nate, prha, max.
Harbormaster failed remote builds in B16709: Diff 20381!Aug 7 2020, 9:40 PM
johann updated this revision to Diff 20385.Aug 7 2020, 10:19 PM

modify config

Harbormaster completed remote builds in B16713: Diff 20385.Aug 7 2020, 10:37 PM
johann updated this revision to Diff 20388.Aug 7 2020, 11:21 PM

test that it fails without fixing diff

johann updated this revision to Diff 20390.Aug 7 2020, 11:34 PM

reset change

johann edited the summary of this revision. (Show Details)Aug 7 2020, 11:39 PM
Harbormaster completed remote builds in B16717: Diff 20390.Aug 7 2020, 11:49 PM
Harbormaster failed remote builds in B16715: Diff 20388!Aug 7 2020, 11:56 PM
Harbormaster failed remote builds in B16717: Diff 20390!Aug 8 2020, 12:19 AM
johann updated this revision to Diff 20394.Aug 8 2020, 11:48 AM

rebase

Harbormaster completed remote builds in B16717: Diff 20390.Aug 8 2020, 12:04 PM
Harbormaster failed remote builds in B16721: Diff 20394!
Harbormaster completed remote builds in B16721: Diff 20394.Aug 8 2020, 12:52 PM
johann added a reviewer: yuhan.Aug 12 2020, 2:14 PM
yuhan accepted this revision.Aug 12 2020, 9:28 PM

yaytests

This revision is now accepted and ready to land.Aug 12 2020, 9:28 PM
Closed by commit R1:3b83a22ae9d4: test subset execution in celery-k8s (authored by johann). · Explain WhyAug 12 2020, 10:08 PM
This revision was automatically updated to reflect the committed changes.
johann added a commit: R1:3b83a22ae9d4: test subset execution in celery-k8s.

Revision Contents
Changeset List

PathSize
integration_tests/
test_suites/
celery-k8s-integration-test-suite/
38 lines
python_modules/
dagster-test/
dagster_test/
test_project/
environments/
10 lines

Diff 20488

View Options

integration_tests/test_suites/celery-k8s-integration-test-suite/test_integration.py

Loading...
View Options

python_modules/dagster-test/dagster_test/test_project/environments/env_subset.yaml

Loading...