Page MenuHomePhabricator

add editable image to dagster-image
ClosedPublic

Authored by johann on Aug 6 2020, 10:57 PM.

Details

Summary

Part 1 of replacing build.sh scripts

  • Wrapper for copying files into buildcache for editable install
  • Editable celery worker image

TODO:

  • For editable images should we include a GUID in the tag? Since the plan is to use them in tests the timestamps may get a conflict
  • test that tries to build each image
  • does any directory that gets copied need find . \( -name '*.egg-info' -o -name '*.tox' -o -name 'dist' \) | xargs rm -rf (from build.sh)
Test Plan

manual

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

johann added reviewers: nate, catherinewu.
johann retitled this revision from add utils to dagster-image to add editable image to dagster-image.
johann added inline comments.
python_modules/automation/automation/docker/images/k8s-celery-worker-editable/Dockerfile
7

Do we need this? (from internal celery image)

nate added inline comments.
python_modules/automation/automation/docker/images/k8s-celery-worker-editable/Dockerfile
7

looks like it would just disable installing the packages under Recommends, might as well include it, I don't think we need this stuff:

root@082fda077f67:/# apt-cache depends cron
cron
  PreDepends: init-system-helpers
  Depends: libc6
  Depends: libpam0g
  Depends: libselinux1
  Depends: debianutils
  Depends: sensible-utils
  Depends: adduser
  Depends: lsb-base
  Depends: libpam-runtime
 |Recommends: <default-mta>
    exim4-daemon-light
  Recommends: <mail-transport-agent>
    citadel-server
    courier-mta
    dma
    esmtp-run
    exim4-daemon-heavy
    exim4-daemon-light
    msmtp-mta
    nullmailer
    opensmtpd
    postfix
    qmail-run
    sendmail-bin
  Suggests: anacron
  Suggests: logrotate
  Suggests: checksecurity
This revision is now accepted and ready to land.Aug 7 2020, 3:25 PM
johann edited the summary of this revision. (Show Details)

update k8s-example image

This revision was automatically updated to reflect the committed changes.