Page MenuHomePhabricator

k8s scheduler and k8s user code deployment docs
ClosedPublic

Authored by catherinewu on Aug 6 2020, 4:37 PM.

Details

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

LGTM - @johann do you want to take a look before Cat lands this?

Nice! LGTM, just a few nits

docs/next/public/assets/images/deploying/k8s_deployment_part2.png
1

workspace.yaml is now generated from userDeployments config

This could be mentioned explicitly, it might be missed in the diagram

The run launcher is not a k8s object but is instead instantiated within other parts of the system

This is kind of confusing. Maybe it could be partly overlayed on dagit and duplicated on the scheduler to show what you mean

docs/next/src/pages/deploying/k8s_part2.mdx
63
65
This revision is now accepted and ready to land.Aug 6 2020, 8:40 PM