Page MenuHomePhabricator

(instance-scheduler-1) Update sidebar navigation for schedules
ClosedPublic

Authored by sashank on Aug 4 2020, 9:03 AM.

Details

Summary

In preparation for the instance level scheduler page, this diff replaces the awkward Schedules button in the repository-scoped section of the left hand nav. It became extra confusing to have both a Scheduler and Schedules button.

Instead, we now have a full list of schedules inline, rendered similarly to how the pipelines and solids are rendered. A small added bonus is that you can see which schedules are running directly from the navigation menu.

The new Scheduler page is still an empty shell.

I'm completely open to feedback about the design, and am also happy to revert to something similar to what we had before if we don't want to prominently display the schedules like this.

Test Plan

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sashank updated this revision to Diff 20024.Aug 4 2020, 9:03 AM
sashank created this revision.

lint

sashank edited the summary of this revision. (Show Details)Aug 4 2020, 9:10 AM
sashank edited the test plan for this revision. (Show Details)
sashank edited the summary of this revision. (Show Details)
sashank edited the summary of this revision. (Show Details)
Harbormaster returned this revision to the author for changes because remote builds failed.Aug 4 2020, 9:21 AM
Harbormaster failed remote builds in B16412: Diff 20023!
Harbormaster failed remote builds in B16413: Diff 20024!
sashank updated this revision to Diff 20027.Aug 4 2020, 9:30 AM
sashank edited the summary of this revision. (Show Details)

update snapshots

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 4 2020, 9:45 AM
Harbormaster failed remote builds in B16416: Diff 20027!
sashank requested review of this revision.Aug 4 2020, 4:53 PM
bengotow accepted this revision.Aug 4 2020, 9:30 PM

I really like this. With schedules getting so many cool features I think they deserve more top level representation.

The only potentially strange thing here is what happens when the list of pipelines is really long. I'd vote to compact the pipelines section enough that the Schedules section is still visible beneath it, so both of them would have scrollbars and wouldn't get pushed offscreen.

I could also see expanding the pipelines vs. solids picker into a three-way segmented control and having a single content section, like this (screenshot below). But I think that in that case it's a little unclear where the "View All" button would live, so this may be better!

This revision is now accepted and ready to land.Aug 4 2020, 9:30 PM

Good call on the length!

I'd vote to compact the pipelines section enough that the Schedules section is still visible beneath it, so both of them would have scrollbars and wouldn't get pushed offscreen.

This sounds good - I'll add this for now. The View All button is still pretty useful.

sashank updated this revision to Diff 20168.Aug 5 2020, 6:35 PM

flexbox

sashank updated this revision to Diff 20210.Aug 5 2020, 10:39 PM

update snapshots