Page MenuHomePhabricator

fix {mem,fs}_intermediate_storage docs and export
ClosedPublic

Authored by aj.nadel on Aug 3 2020, 9:02 PM.

Details

Summary
  • add mem_intermediate_storage and fs_intermediate_storage to dagster module top level (fixes the issue of these not showing up in docs, also, opens them up for general use)
  • add docstring to mem_intermediate_storage so it's not naked in api docs
  • remove superfluous required_resource_keys arg passed to intermediate_storage
Test Plan

existing unit, tested docs manually in local env

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

aj.nadel created this revision.Aug 3 2020, 9:02 PM
aj.nadel requested review of this revision.Aug 3 2020, 9:17 PM
sashank accepted this revision.Aug 3 2020, 9:43 PM
sashank added inline comments.
python_modules/dagster/dagster/core/storage/system_storage.py
129

I would double check that getting rid of this doesn't have any weird side effect

This revision is now accepted and ready to land.Aug 3 2020, 9:43 PM
aj.nadel added inline comments.Aug 3 2020, 11:34 PM
python_modules/dagster/dagster/core/storage/system_storage.py
129

I walked back this change on system_storage because it doesn't have any default behavior. Honestly, this isn't user facing so maybe better just not to touch...

walk back required_resource_keys changes

sashank added inline comments.Aug 4 2020, 5:25 PM
python_modules/dagster/dagster/core/storage/system_storage.py
129

Sounds good - good thing we double checked

This revision was landed with ongoing or failed builds.Aug 6 2020, 9:04 PM
This revision was automatically updated to reflect the committed changes.