Page MenuHomePhabricator

Initial improvements to the solid sidebar

Authored by bengotow on Jun 14 2019, 8:25 PM.



This diff updates the Dagit "solid sidebar":

  • More clearly differentiate the current invocation and the solid definition by splitting the sidebar apart into two sections.
  • Add an "Invocations" tab which shows you all the invocations in the current pipeline and allows you to click to jump to another instance.
  • Make the collapsible headings "sticky" so you can opt to permanently hide Invocations, for example, or jump between invocations without the view resetting.
  • Font sizes in the sidebar are a bit more consistent.

This diff also addresses the issues we had with handle IDs vs solid names. The URL bar is now solid names, not solid handles:

This fixes an issue that prevented clicking to navigate to another solid in the sidebar. In general in Dagit, the methods that allow you to focus / expand, etc. a particular solid all take either a solid name or a solid path, which is generated by splitting a handle.

Test Plan

Give it a spin!

Diff Detail

R1 dagster
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

bengotow created this revision.Jun 14 2019, 8:25 PM
bengotow edited the summary of this revision. (Show Details)Jun 14 2019, 8:30 PM
bengotow edited the test plan for this revision. (Show Details)
bengotow added reviewers: alangenfeld, schrockn.
bengotow edited the summary of this revision. (Show Details)
bengotow updated this revision to Diff 1994.Jun 14 2019, 8:52 PM
  • Fix padding when the pipeline is selected in the sidebar
  • Update the snapshot tests

might need to rebase this if it fails - i just tweaked our CI pipeline this morning

schrockn accepted this revision.Jun 14 2019, 9:17 PM

played with it locally. it's great

This revision is now accepted and ready to land.Jun 14 2019, 9:17 PM
This revision was automatically updated to reflect the committed changes.