displaying asset types in the asset menu
Needs RevisionPublic
Actions

Authored by • leoeer on Jul 29 2020, 9:21 PM.

Details

Reviewers

Summary

adding a column in the asset view to display asset types

Test Plan

Unit

Repository

R1 dagster

Branch

assetdisplay (branched from master)

Lint

Lint Skipped

Unit

No Unit Test Coverage

flake

the build failure is due to a legacy example having issues

image in dagit

js_modules/dagit/src/assets/AssetsRoot.tsx
241	missed this in the original review.... should this be `dagster-type-name`? if we're moving towards having this be used in more places, we may want to consider storing this as a the top-level materialization field instead of jammed in with metadata.
287	It seems pretty heavy to have this be populated for every single asset. Sometimes you just want to record an asset materialization without a type.

phil's changes

rebase

prha requested changes to this revision.Jul 30 2020, 8:16 PM

prha added inline comments.

js_modules/dagit/src/assets/AssetsRoot.tsx
283	I think we should hide this column if it's not present for any of the assets. We're fetching all the data anyway so it shouldn't be a problem to check.
287	We should default to this being blank