adding a column in the asset view to display asset types
Diff Detail
Diff Detail
- Repository
- R1 dagster
- Branch
- assetdisplay (branched from master)
- Lint
Lint Skipped - Unit
No Unit Test Coverage
Event Timeline
js_modules/dagit/src/assets/AssetsRoot.tsx | ||
---|---|---|
241 | missed this in the original review.... should this be dagster-type-name? if we're moving towards having this be used in more places, we may want to consider storing this as a the top-level materialization field instead of jammed in with metadata. | |
287 | It seems pretty heavy to have this be populated for every single asset. Sometimes you just want to record an asset materialization without a type. |
Comment Actions
Yeah the more I think about the more I think this is really heavy and doesn't really take the asset manager in a direction we want to