Page MenuHomePhabricator

Update environment variables loading for SystemCronScheduler
Changes PlannedPublicDraft

Authored by sashank on Jul 29 2020, 7:28 PM.

Details

Reviewers
alangenfeld
Summary

In order to support deprecating the environment_vars argument on ScheduleDefinition, we need to support another way of loading env vars for the SystemCronScheduler. This diff introduced a pre_command configuration option where users can supply a command that can source a file to load the appropriate env vars.

Test Plan

unit

Diff Detail

Repository
R1 dagster
Branch
arcpatch-D4034
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

sashank created this revision.Jul 29 2020, 7:28 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 29 2020, 7:43 PM
Harbormaster failed remote builds in B16166: Diff 19744!
sashank retitled this revision from Update environment variables loading for SystemCronSCheduler to Update environment variables loading for SystemCronScheduler.Jul 30 2020, 8:57 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 30 2020, 9:28 PM
Harbormaster failed remote builds in B16248: Diff 19836!
sashank edited the summary of this revision. (Show Details)Jul 30 2020, 9:48 PM
sashank edited the test plan for this revision. (Show Details)
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 30 2020, 10:11 PM
Harbormaster failed remote builds in B16250: Diff 19838!
Harbormaster returned this revision to the author for changes because remote builds failed.Aug 6 2020, 8:27 AM
Harbormaster failed remote builds in B16616: Diff 20258!
sashank edited the summary of this revision. (Show Details)Aug 6 2020, 8:54 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Aug 6 2020, 9:08 PM
Harbormaster failed remote builds in B16670: Diff 20329!
sashank updated this revision to Diff 22054.Thu, Sep 10, 7:12 PM
sashank edited the summary of this revision. (Show Details)

up

Harbormaster returned this revision to the author for changes because remote builds failed.Thu, Sep 10, 8:17 PM
Harbormaster failed remote builds in B18187: Diff 22054!