Page MenuHomePhabricator

replace grapqhl in raw k8s run launcher
ClosedPublic

Authored by johann on Jul 29 2020, 3:13 PM.

Details

Summary

Replicate celery-k8s run launcher change in raw k8s

Test Plan

unit and integration

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

johann retitled this revision from replace grapqhl in raw k8s run launcher and executor to replace grapqhl in raw k8s run launcher.Jul 29 2020, 3:16 PM
johann edited the summary of this revision. (Show Details)
johann added reviewers: alangenfeld, catherinewu.
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 29 2020, 3:33 PM
Harbormaster failed remote builds in B16148: Diff 19721!
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 29 2020, 4:06 PM
Harbormaster failed remote builds in B16150: Diff 19723!
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 29 2020, 4:37 PM
Harbormaster failed remote builds in B16152: Diff 19726!
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 29 2020, 5:01 PM
Harbormaster failed remote builds in B16154: Diff 19730!

catch different error msg

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 29 2020, 5:18 PM
Harbormaster failed remote builds in B16155: Diff 19731!

parse event logs

integration_tests/test_suites/k8s-integration-test-suite/test_integration.py
62

How can I recreate these tests? With the event log?

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 29 2020, 6:14 PM
Harbormaster failed remote builds in B16158: Diff 19736!
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 29 2020, 6:33 PM
Harbormaster failed remote builds in B16159: Diff 19737!

hack to see event records

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 29 2020, 7:10 PM
Harbormaster failed remote builds in B16162: Diff 19740!
johann marked an inline comment as not done.

update error checks

This revision is now accepted and ready to land.Jul 29 2020, 7:47 PM
This revision was automatically updated to reflect the committed changes.