Page MenuHomePhabricator

use configured in simple_lakehouse example
ClosedPublic

Authored by sandyryza on Jul 15 2020, 12:04 AM.

Details

Summary

Depends on D3883.

Test Plan

bk

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 15 2020, 12:17 AM
Harbormaster failed remote builds in B15348: Diff 18788!
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 22 2020, 12:04 AM
Harbormaster failed remote builds in B15708: Diff 19216!
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 23 2020, 4:19 PM
Harbormaster failed remote builds in B15857: Diff 19386!

looks clean to me

examples/legacy_examples/dagster_examples/simple_lakehouse/lakehouse.py
167

i must have missed the diffs but is having a configured method on the definitions the new set up or do we have both that and the standalone wrapping function?

This revision is now accepted and ready to land.Jul 24 2020, 2:57 PM
examples/legacy_examples/dagster_examples/simple_lakehouse/lakehouse.py
167

ah yeah, we have both

examples/legacy_examples/dagster_examples/simple_lakehouse/lakehouse.py
167

verynice