Page MenuHomeElementl

use table in lakehouse example
ClosedPublic

Authored by sandyryza on Jul 9 2020, 10:07 PM.

Details

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 9 2020, 10:20 PM
Harbormaster failed remote builds in B15014: Diff 18411!
examples/airline_demo/simple_lakehouse/column_types.py
1–23 ↗(On Diff #18415)

when do these get executed?

examples/legacy_examples/dagster_examples/simple_lakehouse/assets.py
1

would be nice to have examples for both computed_asset and computed_table to demo the different usage

examples/airline_demo/simple_lakehouse/column_types.py
1–23 ↗(On Diff #18415)

ah yeah these aren't needed here - they're used for type checking, which is in a separate PR. taking them out.

examples/legacy_examples/dagster_examples/simple_lakehouse/assets.py
1

mind if I implement that in a separate PR? agreed that it would be nice, but table is the correct way to use lakehouse in this case, so would need to contrive a new example to show that off

columns still dont actually do anything right? validation checks coming in future or did i miss a diff

This revision is now accepted and ready to land.Jul 13 2020, 10:29 PM

yeah - they'll get used in future diffs. The materialization diff uses them, and I'm working on something for validation

This revision was landed with ongoing or failed builds.Jul 14 2020, 4:19 PM
This revision was automatically updated to reflect the committed changes.