Page MenuHomePhabricator

[celery docker] add a test
ClosedPublic

Authored by alangenfeld on Jun 26 2020, 9:39 PM.

Details

Summary

Cleans up the config structure a bit as well

depends on D3667

Test Plan

the test

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
alangenfeld added inline comments.Jun 26 2020, 9:40 PM
python_modules/libraries/dagster-celery/dagster_celery/executor_docker.py
50–53 ↗(On Diff #17454)

this could use a better name but wasn't feeling inspired - would appreciate suggestions

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 26 2020, 9:51 PM
Harbormaster failed remote builds in B14194: Diff 17454!
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 26 2020, 10:05 PM
Harbormaster failed remote builds in B14198: Diff 17458!
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 29 2020, 11:09 PM
Harbormaster failed remote builds in B14373: Diff 17643!

eager execute to run in CI

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 30 2020, 4:22 PM
Harbormaster failed remote builds in B14396: Diff 17671!
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 30 2020, 10:40 PM
Harbormaster failed remote builds in B14437: Diff 17726!
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 30 2020, 10:47 PM
Harbormaster failed remote builds in B14438: Diff 17727!
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 1 2020, 3:12 PM
Harbormaster failed remote builds in B14469: Diff 17761!
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 1 2020, 3:25 PM
Harbormaster failed remote builds in B14472: Diff 17764!
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 1 2020, 4:29 PM
Harbormaster failed remote builds in B14480: Diff 17772!
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 1 2020, 7:12 PM
Harbormaster failed remote builds in B14515: Diff 17810!
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 1 2020, 7:51 PM
Harbormaster failed remote builds in B14524: Diff 17819!
alangenfeld requested review of this revision.Jul 1 2020, 8:00 PM

[1] this is needed since we are testing run launchers in these other test suites, run launchers need ExternalPipelines, getting the ExternalPipeline goes through the ExternalRepository, and that grabs the snapshots for all pipelines. So even though the import is lazy it still gets invoked in these other tests.

python_modules/libraries/dagster-celery/tox.ini
19

[1]

python_modules/libraries/dagster-k8s/tox.ini
18

[1]

nate accepted this revision.Jul 1 2020, 11:17 PM

cool, seems pretty reasonable to me

This revision is now accepted and ready to land.Jul 1 2020, 11:17 PM
This revision was automatically updated to reflect the committed changes.