Page MenuHomePhabricator

Add solidDefinitions root call
AbandonedPublic

Authored by schrockn on Jun 11 2019, 5:55 PM.

Details

Summary

This fetches all SolidDefinitions in a repository

Test Plan

Buildkite, run in graphql playground

Diff Detail

Repository
R1 dagster
Branch
add-solid-definitions-to-graphql
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

is this useful on its own without also listing out invocations?

js_modules/dagit/src/schema.graphql
655–656

based on the conversation this is what I thought was being requested:

usedSolidDefinitions: [UsedSolidDefinition!]!


type UsedSolidDefinition {
  definition: ISolidDefinition,
  invocations: [Invocation!]!
}

type Invocation {
  pipeline: Pipeline,
  solidHandle: SolidHandle
}

but with better names

question from before still stands but theres no reason that this cant go in as is

This revision is now accepted and ready to land.Jun 18 2019, 4:01 PM

oh I missed that. that's an interesting change

will address this later