Page MenuHomePhabricator

Add execute run API to dagster cli for launcher to stop using dagster-graphql
ClosedPublic

Authored by johann on Jun 25 2020, 6:40 PM.

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
johann updated this revision to Diff 19611.Mon, Jul 27, 10:27 PM

reduce bk steps

johann updated this revision to Diff 19612.Mon, Jul 27, 10:29 PM

debug statements in can_terminate

johann updated this revision to Diff 19614.Mon, Jul 27, 10:43 PM

put errors in buffer

johann updated this revision to Diff 19628.Tue, Jul 28, 3:56 AM

re originated pipeline

johann updated this revision to Diff 19634.Tue, Jul 28, 2:00 PM

change path

johann updated this revision to Diff 19640.Tue, Jul 28, 4:17 PM

fix origin

johann updated this revision to Diff 19645.Tue, Jul 28, 5:21 PM

pass correct pipeline name

johann updated this revision to Diff 19649.Tue, Jul 28, 6:00 PM

remove prints

johann updated this revision to Diff 19651.Tue, Jul 28, 6:19 PM

fix lints

johann updated this revision to Diff 19655.Tue, Jul 28, 6:47 PM

clean up

johann updated this revision to Diff 19662.Tue, Jul 28, 7:21 PM

import dagster-aws

johann updated this revision to Diff 19667.Tue, Jul 28, 7:45 PM

remove unit test of reoriginated pipeline

alangenfeld accepted this revision.Tue, Jul 28, 8:57 PM

finallydone

maybe hold off on landing this till after the weekly on Thursday. We can pile up all the diffs that move off the dagster-graphql stuff and land them together.

integration_tests/python_modules/dagster-k8s-test-infra/dagster_k8s_test_infra/integration_utils.py
76–87

add some more details to the comments about why this does what it does

81

external_pipeline.get_external_pipeline_data

this looks weird, get_external_pipeline_data is not a function ? or do we not check the incoming input argument

integration_tests/test_suites/celery-k8s-integration-test-suite/test_integration.py
64

I think we could always have the get_test_project_external_pipeline return the ReOriginatedExternalPipelineForTest potentially - in a follow up

python_modules/libraries/dagster-celery-k8s/dagster_celery_k8s/launcher.py
178–192

clean up - tag with a github issue about depending on the receiving cli instance to be the same

johann marked 3 inline comments as done.Tue, Jul 28, 10:16 PM
johann updated this revision to Diff 19692.Tue, Jul 28, 10:16 PM

diff feedback