Page MenuHomeElementl

Add execute run API to dagster cli for launcher to stop using dagster-graphql
ClosedPublic

Authored by johann on Jun 25 2020, 6:40 PM.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

debug statements in can_terminate

pass correct pipeline name

remove unit test of reoriginated pipeline

finallydone

maybe hold off on landing this till after the weekly on Thursday. We can pile up all the diffs that move off the dagster-graphql stuff and land them together.

integration_tests/python_modules/dagster-k8s-test-infra/dagster_k8s_test_infra/integration_utils.py
76–87

add some more details to the comments about why this does what it does

81

external_pipeline.get_external_pipeline_data

this looks weird, get_external_pipeline_data is not a function ? or do we not check the incoming input argument

integration_tests/test_suites/celery-k8s-integration-test-suite/test_integration.py
64

I think we could always have the get_test_project_external_pipeline return the ReOriginatedExternalPipelineForTest potentially - in a follow up

python_modules/libraries/dagster-celery-k8s/dagster_celery_k8s/launcher.py
178–192

clean up - tag with a github issue about depending on the receiving cli instance to be the same