Page MenuHomePhabricator

diff for Ben
AbandonedPublic

Authored by schrockn on Jun 9 2019, 10:07 PM.

Details

Reviewers
bengotow
Summary

patch me

Test Plan

patch me

Diff Detail

Repository
R1 dagster
Branch
solid-handle (branched from master)
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

schrockn created this revision.Jun 9 2019, 10:07 PM
bengotow accepted this revision.Jun 9 2019, 10:10 PM
bengotow added a subscriber: bengotow.

Looks good to me! I guess we may want to think about whether handleID is still the best word for this. Implementation aside, it seems like solids could have a unique key or id, or if we want to formalize the dot-notation used for them, we could call it a path.

This revision is now accepted and ready to land.Jun 9 2019, 10:10 PM
schrockn planned changes to this revision.Jun 9 2019, 10:17 PM

this was wrong

schrockn abandoned this revision.Jun 9 2019, 10:38 PM