Page MenuHomePhabricator

(dagster-cli-api-run-launcher-8) Incremental Strategy for porting dagster-graphql tests
AbandonedPublic

Authored by schrockn on Fri, May 22, 4:21 AM.

Details

Reviewers
max
alangenfeld
Summary

This is a proposal more than anything. My goal is the
use this strategy simualtaneousy move all executions to be
out-of-process and invoked over the cli api and to
consolidate start/launch in the product as well.

The proposal to migrate over the test suite test by test by saying
that if the run launcher if configured to point to cli run launcher,
then we actually intend for the start behavior to do a "launch".

This will allow us to move tests over one-by-one and ferret out bugs.

Once we convert the entire test suite when we can then delete all the
old start code.

Then we can actually eliminate the graphql schema related to the
"start".

I've tested this with some basic pipelines in dagit and it works.

Depends on D3045

Test Plan

BK

Diff Detail

Repository
R1 dagster
Branch
dagster-cli-api-run-launcher-8
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

schrockn created this revision.Fri, May 22, 4:21 AM
schrockn updated this revision to Diff 14533.Fri, May 22, 4:40 AM
schrockn edited the summary of this revision. (Show Details)
schrockn added reviewers: max, alangenfeld.

up

schrockn requested review of this revision.Fri, May 22, 4:55 AM
schrockn abandoned this revision.Sat, May 23, 4:11 PM

going to do a different approach

Abandoned in favor of test infra here https://dagster.phacility.com/D3074 and adoption strategy https://dagster.phacility.com/D3080