Page MenuHomePhabricator

(dagster-cli-api-run-launcher-7) Add APIs to RunLauncher for termination support
ClosedPublic

Authored by schrockn on Thu, May 21, 11:57 PM.

Details

Summary

See title. This workstream will deprecate the execution manager
and it supports termiation. Eventually other run launchers should support
termination as well.

Depends on D3051

Test Plan

BK

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schrockn created this revision.Thu, May 21, 11:57 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Fri, May 22, 12:09 AM
Harbormaster failed remote builds in B11789: Diff 14502!
Harbormaster returned this revision to the author for changes because remote builds failed.Fri, May 22, 2:32 AM
Harbormaster failed remote builds in B11800: Diff 14514!
schrockn requested review of this revision.Fri, May 22, 4:12 AM
max accepted this revision.Fri, May 22, 5:47 PM
max added inline comments.
python_modules/dagster/dagster/core/launcher/base.py
34

is this intended to be sync or async?

This revision is now accepted and ready to land.Fri, May 22, 5:47 PM
schrockn added inline comments.Fri, May 22, 6:31 PM
python_modules/dagster/dagster/core/launcher/base.py
34

sync

schrockn updated this revision to Diff 14578.Fri, May 22, 7:08 PM

great question from max. that was not what the actual behavior was