Page MenuHomePhabricator

Fix k8s run launcher bug
ClosedPublic

Authored by catherinewu on Thu, May 21, 3:21 AM.

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

catherinewu created this revision.Thu, May 21, 3:21 AM
catherinewu requested review of this revision.Thu, May 21, 3:33 AM
catherinewu retitled this revision from run tests against buildkite to Fix k8s run launcher bug.Thu, May 21, 5:55 AM
catherinewu edited the summary of this revision. (Show Details)
catherinewu edited the test plan for this revision. (Show Details)
catherinewu added a reviewer: nate.
nate accepted this revision.Thu, May 21, 5:58 AM
This revision is now accepted and ready to land.Thu, May 21, 5:58 AM
catherinewu edited the summary of this revision. (Show Details)

test

improve type

Harbormaster completed remote builds in B11711: Diff 14396.
catherinewu requested review of this revision.Thu, May 21, 7:27 AM
catherinewu added inline comments.
python_modules/libraries/dagster-k8s/dagster_k8s/job.py
285–289

@nate lmk what you think of changing this? I think this matches more closely with their types

285–289

their = kubernetes

nate added inline comments.Thu, May 21, 2:13 PM
python_modules/libraries/dagster-k8s/dagster_k8s/job.py
285–289

yeah I think this makes sense

nate accepted this revision.Thu, May 21, 4:48 PM
This revision is now accepted and ready to land.Thu, May 21, 4:48 PM
This revision was automatically updated to reflect the committed changes.