Page MenuHomePhabricator

Add bash_solid
ClosedPublic

Authored by max on Fri, May 15, 11:52 PM.

Details

Summary

This adds a bash solid that can be used with dynamically constructed commands.

Test Plan

Unit

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

max created this revision.Fri, May 15, 11:52 PM
nate added inline comments.Fri, May 15, 11:59 PM
python_modules/libraries/dagster-bash/dagster_bash/solids.py
65

hmm the only reason I had it this way was so that when the arguments for @solid change, we don't have to worry about forgetting to update this code. Any thoughts on avoiding the drift?

max added inline comments.Sat, May 16, 12:02 AM
python_modules/libraries/dagster-bash/dagster_bash/solids.py
65

damned if we do damned if we don't

Harbormaster returned this revision to the author for changes because remote builds failed.Sat, May 16, 12:10 AM
Harbormaster failed remote builds in B11500: Diff 14134!
max requested review of this revision.Sat, May 16, 12:28 AM
nate accepted this revision.Sat, May 16, 1:42 AM
This revision is now accepted and ready to land.Sat, May 16, 1:42 AM
This revision was automatically updated to reflect the committed changes.