Page MenuHomePhabricator

Use external classes in compute_step_keys_to_execute
ClosedPublic

Authored by max on Thu, May 14, 8:50 PM.

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

max created this revision.Thu, May 14, 8:50 PM
max requested review of this revision.Thu, May 14, 9:02 PM
schrockn accepted this revision.Thu, May 14, 10:16 PM

thankyou

python_modules/dagster/dagster/core/host_representation/external.py
193–228

cool. a comment that this is copy paste job with a link to an issue would be good. (to be clear i support copy paste for now)

This revision is now accepted and ready to land.Thu, May 14, 10:16 PM
max updated this revision to Diff 14077.Thu, May 14, 10:25 PM

add comment and reference to issue

This revision was automatically updated to reflect the committed changes.