Page MenuHomePhabricator

Remove _object methods from IntermediateStore
AcceptedPublic

Authored by sandyryza on Wed, May 13, 4:00 PM.

Details

Reviewers
max
Summary

This sits on top of https://dagster.phacility.com/D2917.

Its aim is to make IntermediateStore operate at a single layer of abstraction, instead of at both the "object" and "value levels.

Also, this makes it so that "has" goes through the TypeStoragePlugin, like "get" and "set" already do. By delegating "has" to the TypeStoragePlugin as well, we could support, say, a SQLSelectable type that implements "has" by querying a database to see if the table exists.

Test Plan

Updated tests

Diff Detail

Repository
R1 dagster
Branch
type_storage_has_value (branched from master)
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

sandyryza created this revision.Wed, May 13, 4:00 PM
sandyryza updated this revision to Diff 13878.Wed, May 13, 4:55 PM
  • remove intermediate_store.get_object
  • addendum
  • addendum to remove intermediate_store.get_object
sandyryza retitled this revision from type_storage_plugin.has_value to Remove _object methods from IntermediateStore.Wed, May 13, 5:01 PM
sandyryza edited the summary of this revision. (Show Details)
sandyryza edited the test plan for this revision. (Show Details)
Harbormaster returned this revision to the author for changes because remote builds failed.Wed, May 13, 5:59 PM
Harbormaster failed remote builds in B11304: Diff 13878!
sandyryza updated this revision to Diff 13894.Wed, May 13, 6:48 PM
  • carry it all the way up to memoization and uncovered_inputs
Harbormaster returned this revision to the author for changes because remote builds failed.Wed, May 13, 7:04 PM
Harbormaster failed remote builds in B11312: Diff 13894!
sandyryza updated this revision to Diff 13922.Wed, May 13, 9:02 PM

resolve_dagster_type in set_ and has_

Harbormaster returned this revision to the author for changes because remote builds failed.Wed, May 13, 9:16 PM
Harbormaster failed remote builds in B11328: Diff 13922!
sandyryza updated this revision to Diff 13938.Wed, May 13, 10:12 PM
  • carry it all the way up to memoization and uncovered_inputs
Harbormaster returned this revision to the author for changes because remote builds failed.Wed, May 13, 10:26 PM
Harbormaster failed remote builds in B11344: Diff 13938!
sandyryza updated this revision to Diff 13945.Wed, May 13, 10:41 PM
  • Lint and black
Harbormaster returned this revision to the author for changes because remote builds failed.Wed, May 13, 10:53 PM
Harbormaster failed remote builds in B11351: Diff 13945!
sandyryza updated this revision to Diff 13951.Wed, May 13, 11:10 PM

Fix gcs test

Harbormaster returned this revision to the author for changes because remote builds failed.Wed, May 13, 11:23 PM
Harbormaster failed remote builds in B11356: Diff 13951!
Harbormaster returned this revision to the author for changes because remote builds failed.Thu, May 14, 3:48 AM
Harbormaster failed remote builds in B11380: Diff 13975!
sandyryza updated this revision to Diff 14041.Thu, May 14, 8:24 PM
  • fix gcs again
Harbormaster returned this revision to the author for changes because remote builds failed.Thu, May 14, 8:37 PM
Harbormaster failed remote builds in B11430: Diff 14041!
sandyryza requested review of this revision.Thu, May 14, 10:03 PM
max accepted this revision.Fri, May 15, 4:27 PM
This revision is now accepted and ready to land.Fri, May 15, 4:27 PM