Page MenuHomePhabricator

Remove _intermediate methods from IntermediateStore
ClosedPublic

Authored by sandyryza on Wed, May 13, 3:33 PM.

Details

Summary

IntermediateStore operates at three layers of abstraction:

  • Its _object methods deal with serialization strategies
  • Its _value methods deal with type storage plugins and fall back to the _object methods
  • Its _intermediate methods wrap its _value methods but accept step_keys instead of paths

On top of this, IntermediatesManager has methods that do the same thing as IntermediateStore's
_intermediate methods, without delegating to them.

Test Plan

bk

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sandyryza created this revision.Wed, May 13, 3:33 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Wed, May 13, 3:47 PM
Harbormaster failed remote builds in B11299: Diff 13873!
sandyryza updated this revision to Diff 13877.Wed, May 13, 4:53 PM

Unused import

sandyryza requested review of this revision.Wed, May 13, 5:07 PM
max accepted this revision.Wed, May 13, 6:13 PM
This revision is now accepted and ready to land.Wed, May 13, 6:13 PM
This revision was automatically updated to reflect the committed changes.