Page MenuHomePhabricator

[doc] code block fix
ClosedPublic

Authored by yuhan on Tue, May 12, 3:46 AM.

Details

Summary

address a few feedback from beau

  • make line numbers unselectable

  • remove extra lines

won't do

  • remove prompt [punted]

Test Plan

yarn dev

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

yuhan created this revision.Tue, May 12, 3:46 AM
yuhan edited the summary of this revision. (Show Details)Tue, May 12, 3:48 AM
yuhan added reviewers: sashank, nate.
yuhan requested review of this revision.Tue, May 12, 4:01 AM
sashank accepted this revision.Tue, May 12, 4:33 AM
sashank added inline comments.
docs/next/src/pages/docs/tutorial/setup.mdx
68

We have several more of these, if you grep for: $ dagster or $ dagit

This revision is now accepted and ready to land.Tue, May 12, 4:33 AM
yuhan updated this revision to Diff 13720.Tue, May 12, 5:39 AM

up

docs/next/src/pages/docs/tutorial/setup.mdx
68

i realized we sometimes do need the prompt $ to differentiate the cmd from the console output. im gonna keep the $ for now.

yuhan edited the summary of this revision. (Show Details)Tue, May 12, 6:10 AM
This revision was automatically updated to reflect the committed changes.