Page MenuHomePhabricator

Move docker test project utilities to separate package
ClosedPublic

Authored by sashank on Fri, May 8, 3:43 PM.

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sashank created this revision.Fri, May 8, 3:43 PM
sashank retitled this revision from Move docker test project utilities to seperate package to Move docker test project utilities to separate package.Fri, May 8, 3:50 PM
sashank requested review of this revision.Fri, May 8, 4:26 PM
max requested changes to this revision.Tue, May 12, 1:25 AM

It would be nice to name this something that doesn't look as much like an installable client library, and to have a README that explains what it is and not to install it.

This revision now requires changes to proceed.Tue, May 12, 1:25 AM
sashank requested review of this revision.Tue, May 12, 3:55 PM

It would be nice to name this something that doesn't look as much like an installable client library,

I think we'll move things like the run storage test suite and various test suite base classes to this package, so that users can eventually install this package and use them. It will help reduce the size of dagster core as well.

For ex:

from dagster_test import RunStorageTests
sashank updated this revision to Diff 13728.Tue, May 12, 4:04 PM

Update README

nate added a comment.Tue, May 12, 4:09 PM

yeah if we are also moving stuff from dagster core here also, dagster_test seems preferable - I think we'll want to see about making some of our docker, k8s, helm, etc. stuff less buildkite-specific and then moving it here also

max accepted this revision.Tue, May 12, 4:28 PM
This revision is now accepted and ready to land.Tue, May 12, 4:28 PM
This revision was automatically updated to reflect the committed changes.