Page MenuHomePhabricator

Tutorial overhaul 2/ -- rearrange examples
ClosedPublic

Authored by yuhan on Tue, Apr 28, 1:25 AM.

Details

Summary

Depends on D2611.

structured tutorial code into different folders, based on the new tutorial sections

Test Plan

went through the tutorial and ran code

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

yuhan created this revision.Tue, Apr 28, 1:25 AM
yuhan edited the summary of this revision. (Show Details)Tue, Apr 28, 1:31 AM
yuhan added a parent revision: D2611: Tutorial overhaul 1/.
yuhan edited the summary of this revision. (Show Details)Tue, Apr 28, 1:35 AM
yuhan added reviewers: sashank, nate.
yuhan requested review of this revision.Tue, Apr 28, 1:42 AM
nate added inline comments.Tue, Apr 28, 11:34 PM
docs/next/src/pages/docs/tutorial/advanced.mdx
31

hmm can we style this block differently? since it's kind of an aside, it might be nice to have a smaller font, italic, or something. I like how GCP has these asides for product stages:

(pulled from https://cloud.google.com/bigquery/docs/information-schema-reservations)

maybe something similar? @sashank maybe you have some ideas here?

sashank added inline comments.Tue, Apr 28, 11:35 PM
docs/next/src/pages/docs/tutorial/advanced.mdx
31

i can take care of this

nate requested changes to this revision.Tue, Apr 28, 11:35 PM

are the code examples here copied, or do they need review? otherwise see one comment—will mark this as requested changes for q management

This revision now requires changes to proceed.Tue, Apr 28, 11:35 PM
yuhan added a comment.Thu, Apr 30, 5:48 AM

@nate It's just moving the code around.
I didn't change the code, except for enabling the relative path dataset_path = os.path.join(os.path.dirname(__file__), '../../cereal.csv') in code -- users should be able to execute the pipeline with relative csv file path

sashank accepted this revision.Thu, Apr 30, 6:20 PM

Looks good - will just need to update the navbar to use the new file defined in https://dagster.phacility.com/D2695 after it lands

docs/next/src/pages/docs/tutorial/advanced.mdx
31

Something like this?

sashank accepted this revision.Thu, Apr 30, 7:55 PM
This revision was not accepted when it landed; it landed in state Needs Review.Thu, Apr 30, 7:58 PM
This revision was automatically updated to reflect the committed changes.
yuhan added inline comments.Tue, May 12, 3:23 AM
docs/next/src/pages/docs/tutorial/advanced.mdx
31

@sashank circle back to this one. are you still working on it?