Page MenuHomePhabricator

GraphQL query for run groupings
ClosedPublic

Authored by max on Apr 7 2020, 11:13 PM.

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

max created this revision.Apr 7 2020, 11:13 PM
max updated this revision to Diff 11570.Apr 8 2020, 4:42 AM

update schema

max planned changes to this revision.Apr 8 2020, 8:45 PM
max updated this revision to Diff 12524.Apr 23 2020, 11:10 PM

Rebase

alangenfeld added inline comments.Apr 24 2020, 3:56 PM
js_modules/dagit/src/schema.graphql
950

re: my feelings on more explicit names for the args here given the complex behavior from base diff

schrockn requested changes to this revision.Apr 25 2020, 3:43 PM

Code seems fine. This may be answered in a diff elsewhere, but is there a 1:1 relationship between root run id and group or a 1:N relationship?

js_modules/dagit/src/schema.graphql
810–960

I don't understand the ontology here. Shouldn't this fetch a single group?

This revision now requires changes to proceed.Apr 25 2020, 3:43 PM
yuhan commandeered this revision.Tue, May 5, 9:46 PM
yuhan planned changes to this revision.
yuhan edited reviewers, added: max; removed: yuhan.

splitting this and D2444 into

get_run_group
PipelineRunGroup
get_run_groups
PipelineRunGroups

max commandeered this revision.Wed, May 13, 6:59 PM
max edited reviewers, added: yuhan; removed: max.
max updated this revision to Diff 13957.Thu, May 14, 1:19 AM

fixup

max planned changes to this revision.Thu, May 14, 1:19 AM
max updated this revision to Diff 13958.Thu, May 14, 1:26 AM

schema

schrockn requested changes to this revision.Thu, May 14, 1:57 AM
schrockn added inline comments.
python_modules/dagster-graphql/dagster_graphql/implementation/fetch_runs.py
108–110

delete

112–114

I've been trying to move to directly reference classes instead of the type registry. e.g. DauphinRunGroup as opposed to graphene_info.schema.type_named('RunGroup')

python_modules/dagster-graphql/dagster_graphql/schema/roots.py
124–129

should probably make this runGroupsOrError

This revision now requires changes to proceed.Thu, May 14, 1:57 AM
max updated this revision to Diff 13969.Thu, May 14, 2:53 AM

feedback

schrockn requested changes to this revision.Thu, May 14, 4:26 PM
schrockn added inline comments.
js_modules/dagit/src/schema.graphql
951

still not runGroupsOrError

This revision now requires changes to proceed.Thu, May 14, 4:26 PM
max updated this revision to Diff 14016.Thu, May 14, 6:38 PM

generate schema

schrockn accepted this revision.Thu, May 14, 6:47 PM
This revision is now accepted and ready to land.Thu, May 14, 6:47 PM
max updated this revision to Diff 14151.Mon, May 18, 4:27 AM

Rebase

This revision was automatically updated to reflect the committed changes.