Page MenuHomePhabricator

#2346-2 [RFC] pass tags and stepkeys to playground
AbandonedPublic

Authored by yuhan on Apr 7 2020, 1:35 AM.

Details

Summary

Depends on D2405.
RFC
New flow:

  • click on RunTable's "Open in Playground"
  • fixme still need to manually copy and paste the absolute path of intermediates
  • tags and stepkeys are passed over to playground so we get the run group info
  • tags showed up on RunTable

Test Plan
  • see screen recording
  • BK

Diff Detail

Repository
R1 dagster
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

yuhan created this revision.Apr 7 2020, 1:35 AM
yuhan edited the summary of this revision. (Show Details)Apr 7 2020, 1:40 AM
yuhan added reviewers: max, prha, alangenfeld, bengotow.
yuhan added a subscriber: nate.Apr 7 2020, 1:44 AM

cc @nate this is a RFC to pass run grouping info to Playground -- so when we want to change some of the configs but still re-execute a pipeline (or a subset), we can still link the run with its group.
mainly for https://github.com/dagster-io/dagster/issues/1993
how do you feel about the new flow?

Just a few drive-by comments, this looks good to me otherwise!

js_modules/dagit/src/execute/PipelineExecutionSetupRoot.tsx
38

This is a JS nit but this should probably be parentRunId for consistency!

42

It looks like this is editing one of the tags to use the provided qs.runId instead of the previous run's value. I'm not sure if there are a lot of links the lead in to this code path, but it seems like this kind of filtering / editing should probably go at the call site where there's more context about why the value should be changed / overridden.

Maybe RunTable.tsx:376-382 below should be converted into a function call that runs this code, so that the URL contains all the correct /new/ tags for the playground and not the old run's tags?

yuhan updated this revision to Diff 11553.Apr 8 2020, 1:31 AM
yuhan marked an inline comment as done.

up

yuhan retitled this revision from #2346-2 [run grouping] pass tags and stepkeys to playground to #2346-2 [RFC] pass tags and stepkeys to playground.Apr 8 2020, 1:32 AM
yuhan planned changes to this revision.Apr 8 2020, 9:02 PM
yuhan abandoned this revision.Apr 24 2020, 7:06 PM

going to rework this