Page MenuHomePhabricator

[docs] Test nextjs build on buildkite
ClosedPublic

Authored by sashank on Mar 31 2020, 3:19 PM.

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sashank created this revision.Mar 31 2020, 3:19 PM
Harbormaster failed remote builds in B9037: Diff 11170!
Harbormaster failed remote builds in B9038: Diff 11171!
Harbormaster failed remote builds in B9281: Diff 11472!
sashank added inline comments.Apr 6 2020, 9:49 PM
.buildkite/pipeline.py
753–754

These are commented temporarily to speed up builds

kevinrodriguez added inline comments.
docs/next/src/components/Sidebar/index.tsx
131

Just in case: there's an interesting package for this kind of scenario, it does all the parsing, undefined producing 'undefined' string scenario and others: clasnames

This revision is now accepted and ready to land.Apr 7 2020, 1:51 AM
sashank added inline comments.Apr 7 2020, 1:53 AM
docs/next/src/components/Sidebar/index.tsx
131

oh nice - we can pull this in if we ever get some complex class name state going on. ideally we shouldn't though.

This revision was automatically updated to reflect the committed changes.