Page MenuHomePhabricator

Use our tokenized text field for log filtering so type: and step: features are easy to find
ClosedPublic

Authored by bengotow on Mar 30 2020, 1:19 AM.

Details

Summary

I started to add a button to filter by "materializations" but it felt weird that it cleared the search. Instead, I made the log filtering bar use the same tokenized text field / typeahead that the runs and solids pages use. The autocompletions show you that you can filter by type or step which should make those features more obvious. Also nice to consistently use the same UI for faceted search.

Test Plan

Run snapshot tests

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

bengotow created this revision.Mar 30 2020, 1:19 AM
prha accepted this revision.Mar 30 2020, 5:04 PM

this looks great!

one small comment... should we be able to specify both step AND type? the fact that they are tokens makes me think that multi-select should be possible, but it's not.

This revision is now accepted and ready to land.Mar 30 2020, 5:04 PM
bengotow updated this revision to Diff 11550.Apr 8 2020, 12:48 AM
  • Properly support filtering by type and step
  • Rebase

One last question on this one: does it totally eliminate free text search?

schrockn requested changes to this revision.Apr 8 2020, 12:58 AM

Yes it seems to. Req'ing changes so we can chat before landing

This revision now requires changes to proceed.Apr 8 2020, 12:58 AM

Sounds good! Yep, I think you now have to press enter after typing freeform text to apply it + search, though that may be best for realistic scenarios with lots of logs

bengotow updated this revision to Diff 11568.Apr 8 2020, 3:53 AM

Update snapshots

I see. Search terms without colons are free text. Hmmm. Loosing the search as you type is a bit of a regression. I wonder if we could do that with properly debouncing interval.

schrockn requested changes to this revision.Apr 10 2020, 7:54 PM

q mgmt. make sure you see comment re free text search

This revision now requires changes to proceed.Apr 10 2020, 7:54 PM
yuhan added a subscriber: yuhan.Apr 10 2020, 8:24 PM
bengotow planned changes to this revision.Apr 15 2020, 12:48 AM

Will revisit this one Friday - I think that this will require a few changes to the tokenizing input to allow the intermediate state to be observed but we can probably do it in a clean way.

bengotow updated this revision to Diff 12616.Apr 24 2020, 11:31 PM

Add option to Tokenizing field to commit as you type for better search behavior

Small note about this one—I made it search / filter as you type but didn't implement debouncing within the tokenizing text field. The old vesion of this control didn't debounce (so the performance shouldn't be any worse than before) and I think that we should actually try to move the log filtering to a web worker or idle callback so that the filtering itself is async. Debouncing the input will likely just make the jank happen at a different moment 😅

schrockn accepted this revision.Apr 25 2020, 3:31 PM

great.

@prha when we add a meaningful key to materializations re: artifacts/assets we will want those to autocomplete in here

This revision is now accepted and ready to land.Apr 25 2020, 3:31 PM
This revision was landed with ongoing or failed builds.Tue, Apr 28, 4:59 PM
This revision was automatically updated to reflect the committed changes.