Page MenuHomePhabricator

(content-addressable-pipeline-snapshots-1) Elimate default_value from graphql schema
ClosedPublic

Authored by schrockn on Mar 25 2020, 3:33 PM.

Details

Summary

Since this is unused, no need to include it in the snaps. This
will make content-addressability easier as the default value as string
is a pretty unstable thing to include (depends on python rev and deps)

Depends on D2331

Test Plan

BK

Diff Detail

Repository
R1 dagster
Branch
arcpatch-D2337
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

schrockn created this revision.Mar 25 2020, 3:33 PM
schrockn updated this revision to Diff 10983.Mar 25 2020, 6:18 PM
schrockn retitled this revision from Elimate default_value from graphql schema to (content-addressable-pipeline-snapshots-1) Elimate default_value from graphql schema.
schrockn edited the summary of this revision. (Show Details)

upmessage

Harbormaster failed remote builds in B8886: Diff 10984!

should we go for broke and just rip out default_value_as_str from the config system entirely?

alangenfeld accepted this revision.Mar 25 2020, 7:13 PM

can be a separate diff if you think its a good idea

This revision is now accepted and ready to land.Mar 25 2020, 7:13 PM

yes let's kill it

Sent via Superhuman ( https://sprh.mn/?vip=schrockn@elementl.com )

schrockn updated this revision to Diff 10993.Mar 25 2020, 7:20 PM

kill default_value_as_sttr

We actually need it because it needs to be incorporated into the hash