Page MenuHomePhabricator

Refactor compute log watching contextmanager to move to the compute log manager
ClosedPublic

Authored by prha on Mar 25 2020, 4:51 AM.

Details

Summary

This recommits D2301, which was reverted due to failures in the windows tests.

This diff fixes those failures by skipping compute log tests when the legacy windows stdio
is not supported (windows python 3.6+, with env var PYTHONLEGACYWINDOWSSTDIO not set.

It also changes some tests that did not handle the difference in windows line separators, and
fixed the tail implementation for windows by swallowing exceptions caused by pytest's stdout
routing.

Test Plan

Diff Detail

Repository
R1 dagster
Branch
prha/compute_log_refactor_2
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

prha created this revision.Mar 25 2020, 4:51 AM
schrockn resigned from this revision.Mar 25 2020, 3:42 PM

will let alex handle as he did original diff

alangenfeld accepted this revision.Mar 25 2020, 3:55 PM
This revision is now accepted and ready to land.Mar 25 2020, 3:55 PM