Page MenuHomePhabricator

inner_plan_iterator diff bug fixes
ClosedPublic

Authored by alangenfeld on Mar 24 2020, 11:57 PM.

Details

Summary
  • fixes missing parens on os.pid call
  • set step_key on the engine event to end the celery and multiproc events
  • revert ExecutionTargetHandle changes
  • fix .push call in dagit frontend for adding tags
Test Plan

added tests
ran sleepy pipeline in multi proc in dagit
hit retry button to re-execute

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alangenfeld created this revision.Mar 24 2020, 11:57 PM
alangenfeld edited the summary of this revision. (Show Details)Mar 24 2020, 11:59 PM
alangenfeld added inline comments.
python_modules/dagster/dagster/core/definitions/handle.py
552–560

reverted this code back to the way it was prior to D2286

This revision is now accepted and ready to land.Mar 25 2020, 12:25 AM
prha added inline comments.Mar 25 2020, 12:32 AM
js_modules/dagit/src/runs/Run.tsx
168

oof

python_modules/dagster/dagster/core/definitions/handle.py
552–560

I'm not sure why this was a significant change.... because it's rebuilding the repository?

python_modules/dagster/dagster/core/engine/engine_multiprocess.py
53

oof

This revision was automatically updated to reflect the committed changes.
alangenfeld added inline comments.
python_modules/dagster/dagster/core/definitions/handle.py
495–498

*

508–511

*

527–531

*

552–560

it has to do with the manual cache entries * and then when we go check that cache to ensure that a particular pipeline was loaded from a target handle. It's all quite dicey.

cc @max since we were just talking about it