Page MenuHomePhabricator

(redo-snap-backed-graphql-8) Snaps for mode, resource, and logger; back graphql
ClosedPublic

Authored by schrockn on Tue, Mar 24, 11:48 PM.

Details

Summary

Redo D2314

Fixes the issue with pipeline.tags in D2314 and adds unit tests.

This adds snaps for Mode, Resource, and Loggers. Uses those
snaps to back the graphql schema

Test Plan

BK. View dagit pipeline viewer, config editor and execution
viewer

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schrockn created this revision.Tue, Mar 24, 11:48 PM
schrockn updated this revision to Diff 10976.Wed, Mar 25, 3:11 PM
schrockn edited the summary of this revision. (Show Details)
schrockn edited the test plan for this revision. (Show Details)

upmessage

schrockn added inline comments.Wed, Mar 25, 3:13 PM
python_modules/dagster-graphql/dagster_graphql_tests/graphql/conftest.py
26

coverage in graphql layer

python_modules/dagster/dagster/core/snap/pipeline_snapshot.py
77

change from D2314

python_modules/dagster/dagster_tests/core_tests/snap_tests/test_pipeline_snapshot.py
12

coverage in snap layer

This revision is now accepted and ready to land.Wed, Mar 25, 7:11 PM