Page MenuHomePhabricator

(redo-snap-backed-graphql-7) Redo Back all dependency-related things via snap
ClosedPublic

Authored by schrockn on Tue, Mar 24, 5:42 PM.

Details

Summary

Redo D2310

Fixed issue and changed test_production_query to cover relevant
codepaths

This uses the pipeline and dependency indexes to back all
dependency-related graphql types.

This is the most thorny part of the graphql schema and I believe it
should be relatively straightforward from here to convert the rest
of the schema to be snapshot backed.

Test Plan

BK. View pipeline. View solids screen. Config Editor. Execute
Pipeline

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schrockn created this revision.Tue, Mar 24, 5:42 PM
schrockn added inline comments.Tue, Mar 24, 5:43 PM
python_modules/dagster-graphql/dagster_graphql/schema/solids.py
46

bug fix here

56–57

and here

python_modules/dagster-graphql/dagster_graphql_tests/graphql/conftest.py
56

updated test case here

alangenfeld accepted this revision.Tue, Mar 24, 10:52 PM
This revision is now accepted and ready to land.Tue, Mar 24, 10:52 PM