Page MenuHomePhabricator

Add hello/email banner, add telemetry banner, add whitelisted function list to code + docs, make telemetry opt-out
AcceptedPublic

Authored by catherinewu on Tue, Mar 24, 8:18 AM.

Details

Reviewers
schrockn
Test Plan

add tests

Diff Detail

Repository
R1 dagster
Branch
telemetry-optout
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

catherinewu created this revision.

up

Harbormaster failed remote builds in B8843: Diff 10933!

check TTY before prompting user for email

I'm not sure whether we should keep the add_email endpoint in the subdomain 'telemetry.dagster.io/'

To avoid creating a new service, we could move/rename

'http://telemetry.dagster.io/actions' => 'http://actions.dagster.io/log_telemetry'
'http://telemetry.dagster.io/add_email' => 'http://actions.dagster.io/add_email'

verified that sys.stdout.isatty() and sys.stdin.isatty()are both false when run from within a docker container

schrockn requested changes to this revision.Mon, Mar 30, 10:43 PM
schrockn added inline comments.
python_modules/dagster/dagster/core/telemetry.py
206

let's do a hard failure here. otherwise people will add telemetry decorator and be very confused as to why it is not working

This revision now requires changes to proceed.Mon, Mar 30, 10:43 PM
schrockn accepted this revision.Tue, Mar 31, 11:25 PM
This revision is now accepted and ready to land.Tue, Mar 31, 11:25 PM